Disabled status subscribers for the docs #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks! Status: reviewed |
|
👍 |
|
I think #58 should be done first IMO |
|
And moving it back to Needs review when doing new changes in the PR is not something you can do with github reviews |
|
actually, I think this PR should not be merged at all (but #58 should be) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in our Slack channel, it's probably better to use the GitHub review API instead of the status labels in the docs.
This PR disables setting the
Needs Reviewlabel on creation and pushing a new commit. I still enabled status change by comment, as status labels still make sense for bug reports imo./cc @javiereguiluz @weaverryan @xabbuh